Edit about the 4chan image blocking, I asked Rimu directly:

I wrote a long message about how that checkbox only notifies about federated posts.

So the difference is for local posts it blocks the creation of the post entirely, but for federated posts it just notifies the admin.

https://chat.piefed.social/#narrow/channel/3-general/topic//near/10529

– Original message:

https://codeberg.org/rimu/pyfedi/src/commit/b168820a089ff6e835059f0d806f81b612987a79/app/models.py#L3513

A few people in the other thread assumed that it was required to fork the code to disable those filters. That’s not the case, the filters can be configured, and are off by default.

To hide the reputation system, here’s a line of CSS that admins can add in the admin area to hide it for every user

https://piefed.social/c/piefed_css/p/1722358/hide-red-triangle-warnings-on-accounts-with-bad-reputation

That CSS line can also be used by any user wanting to hide the score at the user level.

  • goferking (he/him)@lemmy.sdf.org
    link
    fedilink
    English
    arrow-up
    19
    arrow-down
    1
    ·
    29 days ago

    Wasn’t the biggest concern and question why it didn’t do an actual error message and is there any notes to say the performance impact having the 4chan filter on?

    I’d also argue

    To hide the reputation system, here’s a line of CSS that admins can add in the admin area to hide it for every user

    Does absolutely nothing to assure people concerned about it being a thing. Like hiding it doesn’t do anything about it being a thing

    • lambalicious@lemmy.sdf.org
      link
      fedilink
      English
      arrow-up
      6
      arrow-down
      1
      ·
      29 days ago

      Yeah it reeks of “you can complain about CCP-like behaviour but not in a way that actually effects any change”.

  • Rimu@piefed.social
    link
    fedilink
    English
    arrow-up
    16
    arrow-down
    6
    ·
    edit-2
    29 days ago

    Those checkboxes have been there since version 0.9. Ages.

    The problem with grabbing small snippets of code is a lot of context is lost. Don’t trust anyone who does that. PieFed has 50,000 lines of code so anyone showing you 50 lines is leaving out 99.9% of the picture.

    As I said a month ago, anyone with honest questions about how things work who wants to make PieFed better knows where to find us. You don’t have to be a coder, we need translators, designers, documentation writers, bug reporters, community evangelists and all that.

    • goferking (he/him)@lemmy.sdf.org
      link
      fedilink
      English
      arrow-up
      13
      arrow-down
      4
      ·
      29 days ago

      Clean, simple code that is easy to understand and contribute to

      The problem with grabbing small snippets of code is a lot of context is lost. Don’t trust anyone who does that. PieFed has 50,000 lines of code so anyone showing you 50 lines is leaving out 99.9% of the picture.

      These 2 statements are incompatible.

      Plus depending on the snippets they definitely can tell how things work

      • wjs018@piefed.wjs018.xyz
        link
        fedilink
        English
        arrow-up
        7
        arrow-down
        3
        ·
        29 days ago

        Previous threads about these filters were people complaining about them being hardcoded, completely ignoring that they are completely optional and off by default. It would go something like this:


        Look at this awful thing PieFed does!

        def do_the_thing():
            # relatively simple code that does the thing
        

        It completely ignored the context that the do_the_thing function is only called if the admin wants to do the thing.

        • goferking (he/him)@lemmy.sdf.org
          link
          fedilink
          English
          arrow-up
          4
          arrow-down
          1
          ·
          28 days ago

          Most of the issues people have brought up have been about why the snippets are even in the code not trying to obscure what the code does.

          It completely ignored the context that the do_the_thing function is only called if the admin wants to do the thing

          Again it’s why is this a thing

    • Shatur@lemmy.ml
      link
      fedilink
      English
      arrow-up
      8
      ·
      edit-2
      28 days ago

      The problem with grabbing small snippets of code is a lot of context is lost.

      To me, it was obvious that these parts were configurable. There were literally boolean checks for it.

      But these features remind me Reddit. And I’m pretty sure most users simply unaware about these things enabled on the .social instance.

    • lambalicious@lemmy.sdf.org
      link
      fedilink
      English
      arrow-up
      9
      arrow-down
      4
      ·
      29 days ago

      The 99% of the code does not deal with keeping Shadow Profiles on netizens and punishing them (as well as misinforming them about what’s going on). This 50something lines, does, and thus is a weighed key on which to judge the subject.

      , we need […] community evangelists

      What will they be commenting to the public on the CCP-like thing?

    • seawoowaes@lemmy.world
      link
      fedilink
      English
      arrow-up
      3
      arrow-down
      7
      ·
      28 days ago

      get back to work hardcoding censorship and pushing your tankie ideology in your code.

      What is wrong with you? Why would you put malicious code into piefed that deliberately misleads users?

    • goferking (he/him)@lemmy.sdf.org
      link
      fedilink
      English
      arrow-up
      6
      arrow-down
      1
      ·
      29 days ago

      That’s an excellent question. Thought it was one of the check boxes but that one is just for adjusting reputation if post something from 4chan (ie thinks you’re naughty)

  • hector@lemmy.today
    link
    fedilink
    English
    arrow-up
    4
    arrow-down
    1
    ·
    29 days ago

    So what is the lowering reputation part. Are the mods grading your posts and then reducing their visibility?

    I was a bit put off with the de federating from some of the other communities, but I had contact with one that I had to admit really needs to be de Federated from. Hexbear, chapotraphouse. Never had s problem with the .ml or whatever.

    But I noticed some remove the word cunt too, which is a dealbreaker for me.

    • Grail@multiverse.soulism.net
      link
      fedilink
      English
      arrow-up
      2
      arrow-down
      1
      ·
      29 days ago

      If you get reported or post a hot take, admins can look at your karma to see if your takes are usually hot, and at how often you tend to upvote vs downvote. They don’t have to do anything with that information, it’s just to help them tell if a user is controversial

  • fiat_lux@lemmy.world
    link
    fedilink
    English
    arrow-up
    6
    arrow-down
    5
    ·
    29 days ago

    I get that many people are concerned about is scoring systems, but it seems a lot more worrying to me that it allows arbitrary code execution.

    • wjs018@piefed.wjs018.xyz
      link
      fedilink
      English
      arrow-up
      9
      arrow-down
      2
      ·
      29 days ago

      arbitrary

      You mean the Javascript that would need to be written and added by the instance admin? Something that any admin with infra access could do anyway? Hardly seems arbitrary at all. ACE usually means something not intended.

      • Victor@lemmy.world
        link
        fedilink
        English
        arrow-up
        3
        ·
        29 days ago

        I too think the top commenter here hasn’t quite understood what they are seeing in this picture. 😅

      • fiat_lux@lemmy.world
        link
        fedilink
        English
        arrow-up
        2
        arrow-down
        1
        ·
        29 days ago

        Well, just copy and pasted rather than written. I would have hoped that infra read-level permission, infra write-level permission and admin interface permissions were all separate to begin with, even if the person who spun up the instance obviously has all three.

        You do need a level of trust in an admin, of course, but wide open text boxes for putting in code are a questionable system design choice, in my opinion. It adds an extra point of possible entry that then relies on the security of the overall admin interface instead of limiting it to what should require highest level infra admin permissions to access. And if it is something that would be limited to someone who has those, then what is the actual utility of having a textarea for it in the first place?

        • Grail@multiverse.soulism.net
          link
          fedilink
          English
          arrow-up
          1
          ·
          29 days ago

          Oh, I love it. So much freedom to customise our instance without having to rebuild the Docker image or fork the codebase.

          • fiat_lux@lemmy.world
            link
            fedilink
            English
            arrow-up
            1
            ·
            29 days ago

            Out of curiosity, what sort of customizations are you doing with it? I’m just a bit surprised that docker rebuild or a non-trivial fork would be needed, so I’m assuming they’re pretty big changes.

            • Grail@multiverse.soulism.net
              link
              fedilink
              English
              arrow-up
              1
              ·
              29 days ago

              So far I’ve only changed the colour theming, but I like freedom in general. One thing I want to do at some point is change the font of any instance of the string MULTIVERSE, My partner suggested it as a cool branding idea

            • wjs018@piefed.wjs018.xyz
              link
              fedilink
              English
              arrow-up
              1
              ·
              29 days ago

              Some instances have used it to do something like a dynamic message of the day. That is the most I have seen it used for so far.

              Edit: See the top of the main content pane of anarchist.nexus as an example.

      • wjs018@piefed.wjs018.xyz
        link
        fedilink
        English
        arrow-up
        8
        arrow-down
        1
        ·
        29 days ago

        They’re just making shit up. In their mind I guess Javascript that is intentionally included by an admin to customize their instance counts as ACE. In that sense any webserver you ever browse to is capable of ACE.

        • fiat_lux@lemmy.world
          link
          fedilink
          English
          arrow-up
          1
          ·
          29 days ago

          Any webserver you browse is possibly capable of ACE depending on the implementation. When it starts to hold user data is when that starts to be a big concern. The more points of entry, the more that needs to be secured.

          I don’t have any experience with piefed admin, or any opinion on piefed itself, just too many years of web admin experience. And as soon as I see intentionally made doors that allow code input, I start to worry about how much experience the devs who made it have with web admin.

          • lambalicious@lemmy.sdf.org
            link
            fedilink
            English
            arrow-up
            2
            ·
            29 days ago

            Booo. Here I was hoping for something serious to spice up the news and it just turns out it’s “it runs on a browser”.

            • fiat_lux@lemmy.world
              link
              fedilink
              English
              arrow-up
              1
              ·
              29 days ago

              I’m not a spice merchant, and most exploits rarely involve a single step. This screenshot is just a system design red flag.

              You’re free to examine the repo yourself and find your own spice, my 5 min look tells me that piefed needs to expend a significant amount of effort on infosec to maintain user trust in the longer term.

      • fiat_lux@lemmy.world
        link
        fedilink
        English
        arrow-up
        4
        ·
        29 days ago

        As others have pointed out, it does still require (with some caveats about the infra setup) the user to be an admin. But if someone manages to get in to the interface, or another person is granted admin access who shouldn’t have been, it makes it more risky than it needs to be. It also for me is a design choice that indicates other parts of the system should be carefully examined for how they’re handling and sanitizing input.

  • termaxima@slrpnk.net
    link
    fedilink
    English
    arrow-up
    5
    arrow-down
    5
    ·
    29 days ago

    Sounds like these settings are very reasonable to have turned on. Although I would be cautious of how the “4chan” filter is implemented, it sounds easy to overdo.

    • lime!@feddit.nu
      link
      fedilink
      English
      arrow-up
      9
      arrow-down
      1
      ·
      29 days ago

      it ocr’s the image and checks if it contains a long number and the word “anonymous”.

      yes really

  • Rioting Pacifist@lemmy.world
    link
    fedilink
    English
    arrow-up
    3
    arrow-down
    11
    ·
    29 days ago

    I’m in, anything with less Tankies and less channers is good.

    What’s the best instance to use, I assume I can keep my current user and just view posts via piefed.social