Can we stop using npm now?
I swear to god the number of attacks like this or spawned from other attacks like this is fucking stupid. I’ve gender seen anything like it.
This problem has nothing to do with NPM. Checkmarx was compromised last month, and during that compromise there were malicious VS Code extensions published to Visual Studio Code Marketplace. A Bitwarden developer says that somebody ran one of those malicious extensions, and GitHub API keys were stolen which were used in publishing the malicious CLI package.
It’s probably better that it happened on NPM. If the CLI were only downloadable from the Bitwarden website, it would have likely taken longer for somebody to notice something was wrong.
Yes, but NPM has been had countless security problems, this isn’t a new problem. Even tho this instance is not a problem of NPM itself, it still has been proven as one of the most unreliable and insecure package managers out there.
I’m not a particular fan of npm, but you’ll probably see this kind of thing with any package manager of similar size. More a matter of what’s the most attractive target than the package tech itself.
But why does NPM enable post install scripts by default? Why is there no way to define a minimum release age for dependency versions? It’s just poor design choices.
What a fucking asanine series of events.
Genuine question. How is NPM more vulnerable than other repos? Haven’t similar supply chain attacks succeeded at least as well as this one through GitHub itself and even Linux package repos?
Larger standard libraries do a lot. It’s a lot harder to sneak vulnerabilities into the basic C# or Java or C++ libraries than it is to add a vulnerability to something one dude maintains in the javascript ecosystem.
And since javascript libraries tend to be so small and focused, it’s become standard practice for even other libraries to pull in as many of those as they want.
And it stacks. Your libraries pull in other libraries which can pull in their own libraries. I had a project recently where I had maybe a dozen direct dependencies and they ended up pulling in 1,311 total libraries, largely all maintained by different people.
In a more sane ecosystem like C#, all the basics like string manipulation, email, or logging have libraries provided by Microsoft that have oversight when they’re changed. There can be better, third-party libraries for these things (log4net is pretty great), but they have to compete with their reputation and value over the standard library, which tends to be a high bar. And libraries made on top of that system are generally pulling all those same, certified standard libraries. So you pull in 3 libraries and only one of those pulls in another third party single library. And you end up with 4 total third party libraries.
Javascript just doesn’t really have a certified standard library.
(This certified standard library doesn’t have to be proprietary. Microsoft has made C# open source, and Linus Torvalds with the Linux Kernel Organization holds ultimate responsibility for the Linux kernel.)
And since javascript libraries tend to be so small and focused
Lol, LMAO even
Left-pad tho
I don’t think you’ll find another major repo with so many real-world incidents though. Whether this is because of a systemic problem or just because it’s targeted more frequently, I’m not sure.
There’s a lot of features that make it a better package manager but nobody cares. Every project has hundreds of dependencies and packages use a minimum, not exact, version.
That sounds more like bad practices from the community. It definitely has ways to use exact versions. Not the least of which the lock file. Or the shrinkwrap file which public packages should be using.
Then you’re waiting forever on vulnerability patches. Especially if there are layers, and each layer waits to update.
Npm probably has the biggest attack surface and many of the libraries hosted there are in extremely widespread use. They’ve taken some steps to mitigate these supply chain attacks, but as we’ve seen with more recent examples, it’s unrealistic to think they can be prevented completely. Most of these attacks use stolen developer credentials, which invalidates almost all potential security measures on the registry side and the best you can hope for is catching a malicious package quickly. To be clear: I think the JS ecosystem is uniquely positioned to be the prime target of supply chain attacks and while that doesn’t excuse the slow implementation of security measures from the npm team, the people arguing that other package managers and registries aren’t vulnerable to this have to be huffing fumes.
That’s fair, I won’t pretend pypi/pip and running uvx is much safer than npx.
But why hasn’t JavaScript established a defacto stdlib to replace ask the left pads and is even type packages?
I’ve taken a near zero dependency policy on my personal projects regardless, and now I run most code in containers to sandbox it.
But why hasn’t JavaScript established a defacto stdlib to replace ask the left pads and is even type packages?
I’m guessing things were working out pretty alright, even with the insane amount of dependencies per project. The awareness and the increasing frequency of supply chain attacks is relatively recent for npm. But who knows, maybe the tech giants in control of the web standards are happy to keep using their own vendored registries.
It has only been available for 2h30 on NPM, so unless you had the misfortune of installing the latest version in this short window, you should be fine. Thankfully people have been able to quickly catch this.
This is one of the reasons why I update a version or two behind. The other reason is because I’m lazy.
One lie and one truth in this sentence.
I update after I feel all the early adopters have worked out all the bugs for me.
That is a genuinely good strategy.
reposting the tl;dr I wrote from another community…
Yesterday, for about 1h30min (starting at 5:57pm ET / 21:57 UTC) anyone installing the latest version of the command line interface of bitwarden was installing malware.
The malware steals GitHub/npm tokens, .ssh, .env, shell history, GitHub Actions and cloud secrets, then exfiltrates the data to private domains and as GitHub commits and doesn’t seem to be targeting Bitwarden specifically, or user vaults.
There’s no evidence that end user vault data was accessed or at risk, or that production data or production systems were compromised, according to their official statement.
It seems there were 334 bitwarden CLI downloads in this time period, some or many of which might have been from bots, so this is a higher bound to the number of affected users.
I really need to figure out a better sandboxing method for shells. It’s crazy to be things where my keys, browser data, shell history are all accessible.
I do try to use firejail where possible, but it’s quite cumbersome. Every so often I look for tools to help with this, but everything is oriented around making a specific program (e.g. Firefox, steam) work.
For cli I just use podman(/docker) containers. Good enough and I don’t have to learn a new tool
yeah, about twice a year I use the CLI to backup my vault, and I’ve never felt comfortable installing an npm package to handle my vault. Now I’m definitely sandboxing it in a rootless container without internet next time. And installing a week old version, or older.
Me when I break into a bank to steal the employee wallets
Don’t. Use. Npm.
That applies to pip and crate and all the other shitty lang package managers that totally fail at security
What should be used instead?
Easy, just vendor all your dependencies! Can’t have a supply chain attack if you are the supply chain.
A package manager that uses cryptographic signatures. Apt had this since 2005 iirc. Use apt.
deleted by creator
Packages are reviewed by package maintainers.
Humans are required to solve a malicious insider. But most supply chain vulns of these shitty software dependency managers were resolved decades ago by freely available cryptography
deleted by creator
Apt is great, but it does not work with every language. As an example, you cannot use apt with maven (java) AFAIK.
Oh boy. Maven is like the only language dependency manager that does signing tho!
You don’t need to use apt for java. Just use maven :)
Haha! Yeah, I don’t even know where to start if I wanted to use apt for this. I’ll stick with Maven for Java.
what about cargo?
Same problem.
so many workplaces I have been at used npm.
Yep. And so many workplaces have had security vulnerabilities caused by dumb decisions that could have been easily avoided
We just recently switched from npm to pnpm, due to all the supply chain attacks. I did the PR for it, even.
Our release schedule is like a year though so we don’t really have to worry much about releasing compromised dependencies. But still, better to be on the safer side.
Honestly just fine use computers at all, completely eliminate the remote attack vector. And only drink rain water since city water can be compromised.
Or, recognize this is a normal part of using software and have more than 1 thing between you and a breach
The rules of cybersecurity:
-
Under no circumstances should you own a computer.
-
If you absolutely must own a computer, under no circumstances should you connect it to the internet.
-
If you absolutely must connect it to the internet, it’s too late and they already have you
I know this is a joke but im old enough we used to install the os and had it on the network and eventually update it but then it got to the point were like being connected to the internet for like a minute and the machines were compromised. Thats when we got off our duffs and started making custom installs that had updates and configurations and software pre installed before we even connected it to the net.
-
Dude, rain water is full of pollutants too. 😂
Apt works great
And how would apt help in this particular case? A supply chain attack can happen with any particular package manager. In this case, the compromised package was detected and mitigated within 93 minutes, affecting a total of ~330 users. Which is a lot better than how a lot of distros handled the xz breach last year.
All reasonably secure package managers (and https) operate on a chain of trust. There is little that can be done if that chain of trust is broken.
Based on this the cause was a malicious VSCode extension that stole credentials that were later used to trigger a deployment CI/CD pipeline. If there’s anything to learn from this, it’s probably to not use VSCode.
With cryptography. X.509 is trash. They should pin the public key.
- If your assumption is that X509 is trash, does that mean you hold the same amount of distrust to TLS?
- How do you propose the scaling of key management? Do you have a reasonable alternative to users blindly trusting every single key they come across?
- Back to my original question: what prevents a VSCode extension from stealing a private signing key (as opposed to an API key) and causing the same issues described here?
TLS is fine with certificate pinning m
That still leaves two out of three questions unanswered. Most importantly the last one, which was addressed towards the original complaint.
Unfortunately I have to use node for home project (Jellyfin tizen)
I was wondering: would it be possible to run node in a sandbox to lower the scope of the attack? (i.e. not compromise my home computer) Or is maybe a full VM a better solution?
Technically you can use node without npm.
Jellyfin is available in apt
I need to build it, jellyfin-tizen is a separate project for Samsung TVs
I think you need to throw out the Samsung TV to be secure
Wouldn’t verion pinning solve this problem?
Full VM and network isolation. and dont put anything important there (nor a reused password for auth)
What about using pip just to download basic common libraries for offline use?
Don’t do it.
Because they could be changed or have something sneak in the library?
Yeah, without signature checking anything that you download could change to anything else.
That’s a remote code execution vuln.
lots of people recommend bitwarden, but i am more at peace with an offline password manager that i control like Keepass. You can also go the GNU route and use “pass” on Linux too
Or use a physical key like Yubikey to login
No. Offline password managers are also suspectible to supply chain risk.
So is everything else. But KeePass has been a highly reputable password manager for close to 20 years now.
deleted by creator
Only if yubibkey worked for more than the handful of sites/services. I have one for my bitwarden as majority of places want to send a text or us totp.
Also they only half work in Linux I guess? Something about not being able to create something.
I’ve been trialing Vaultwarden for a while and while I do like the server sync setup and clean web access, the Bitwarden browser plugin is just okay despite being an “enterprise” solution. It misses probably about 20% of websites when creating a new account, forcing you to grab the password from the generator history and make a new entry manually.
KeepassXC is much better in that regard, and it’s almost as good as the default credential handler of Firefox, and it lets you set up a bunch of custom stuff to extend the functionality if you want. Plus it has some neat kbdx options aside from AES256.
Only downside is syncing, which I’m debating how I’ll deal with something better than syncthing on android (protocol is great, android makes it a PITA to have a background process if its not Google spyware).
It misses probably about 20% of websites when creating a new account, forcing you to grab the password from the generator history and make a new entry manually.
This makes me so fucking angry. How can a password manager be so bad at storing passwords, it’s like it’s only job. It even is generating the password for you! Aaaaaaaaaaaaaah!
TIL about the generator history
Not super helpful, because every time you open it, it generates a new one, so how do you know which one is the one it generated?
I’ll just keep using keepass.
Keep ass?
You know it
Yeah, as in keep it closed so you don’t get fucked by the hackers.
Does this include the brew version?
What is npm? How do I know I’m not using it?
Short answer: If you don’t know if you’re using it, you’re very likely not using it.
Npm is a package manager for node.js, a programming framework for JavaScript.
If I use the CLI through the bitwarden flatpak am I OK?
